Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the memo validation logic for Soroban transactions by removing the source account authentication check. The change makes all Soroban transactions with memos return an error, regardless of whether they use source account authentication only.
- Removes complex source account authentication validation logic from
validateSorobanMemo - Consolidates memo and muxed account validation into a single condition
- Updates test expectation to reflect stricter memo validation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/herder/TransactionQueue.cpp | Simplifies validateSorobanMemo function by removing source account auth checks and consolidating validation logic |
| src/herder/test/TransactionQueueTests.cpp | Updates test expectation from ADD_STATUS_PENDING to ADD_STATUS_ERROR for Soroban tx with memo |
| .github/copilot-instructions.md | Adds GitHub Copilot instructions for fee bump transaction test coverage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #X
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)